Demonstrate exceptions for goto &NAME #23819
Open
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
requested changes
Oct 9, 2025
There was a problem hiding this comment.
I don't see what this has to do with #23811.
It looks like you're trying to test the Can't goto subroutine from an eval-block error, but we already have a test for that (line 205).
The goto &{ ... } and goto &$foo syntax variants are already exercised by lines 345 and 260 in this file.
| # GH 23811 goto &NAME where block evaluates to coderef | ||
| { | ||
| local $@; | ||
| my $hw = 'hello world'; |
There was a problem hiding this comment.
What is
$hwfor?
The same string is used at lines 382, 391 and 400; hence, store in a variable.
t/op/goto-sub.t
Outdated
| like($@, qr/^Can't goto subroutine from an eval-block/, | ||
| "Can't goto subroutine (block which evaluates to coderef) from an eval block"); | ||
|
|
||
| undef $@; |
There was a problem hiding this comment.
undef $@ is redundant before eval. Every eval resets $@.
There was a problem hiding this comment.
Removed in two locations in next push; thanks.
Provide simple examples of goto &NAME syntax used incorrectly. Addresses: GH Perl#23811 Remove two superfluous statements, per review by @mauke.
jkeenan
force-pushed
the
goto-amp-name-20251006
branch
from
de676ae to
d0a88a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide simple examples of goto &NAME syntax used incorrectly.
Fixes: GH #23811